Update @metamask/eth-keyring-controller#1441
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates
@metamask/eth-keyring-controllerinKeyringControllerto^13.As after
v11.0.0the library has been migrated to TS there is a number of changes needed to support it.Keyringtype used by@metamask/eth-keyring-controller, which is still not supported by the latest released versions of the HD and simple keyrings.Keyringtype from@metamask/utilshas been added, superseding local type declarationsReferences
Changelog
@metamask/keyring-controllerkeyringTypesproperty from the KeyringController stateKeyringControllerOptionstype changedKeyringControllerOptions.stateaccepted type is now{ vault?: string }KeyringControllerOptions.keyringBuilderstype is now{ (): Keyring<Json>; type: string }[]addresstype accepted by theremoveAccountmethod is nowHexsignTypedMessagemethod now returns aPromise<string>signTransactionmethod now requires aTypedTransactionfrom@ethereumjs/tx@^4for thetransactionargument, and returns aPromise<TxData>Keyringtype toKeyringObjectaddNewAccountnow throws if address of new account is not a hex stringexportSeedPhrasenow throws if first keyring does not have a mnemonicverifySeedPhrasenow throws if HD keyring does not have a mnemonicgetAccountKeyringTypetoPromise<string>addQRKeyringhas been renamed to#addQRKeyring@metamask/eth-keyring-controllerto^13.0.0Checklist